Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue incorrect struct name match pattern for command gen service #2125

Merged
merged 8 commits into from
Sep 15, 2022

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Sep 15, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #2125 (6831481) into master (508062f) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2125      +/-   ##
==========================================
+ Coverage   76.41%   76.48%   +0.07%     
==========================================
  Files         516      517       +1     
  Lines       46635    46870     +235     
==========================================
+ Hits        35635    35849     +214     
- Misses       9033     9042       +9     
- Partials     1967     1979      +12     
Flag Coverage Δ
go-1.15-386 76.40% <ø> (?)
go-1.15-amd64 76.39% <ø> (-0.01%) ⬇️
go-1.16-386 76.38% <ø> (?)
go-1.16-amd64 76.39% <ø> (?)
go-1.17-386 76.43% <ø> (?)
go-1.17-amd64 76.43% <ø> (?)
go-1.18-386 76.43% <ø> (+0.07%) ⬆️
go-1.18-amd64 76.37% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/drivers/oracle/oracle.go 84.25% <0.00%> (ø)
os/gfsnotify/gfsnotify_watcher_loop.go 83.19% <0.00%> (+5.04%) ⬆️
contrib/registry/polaris/polaris_watcher.go 73.21% <0.00%> (+5.35%) ⬆️
os/gcache/gcache_adapter_memory_lru.go 97.82% <0.00%> (+8.69%) ⬆️
os/gcron/gcron_schedule_fix.go 100.00% <0.00%> (+12.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@houseme houseme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gqcn gqcn merged commit 5e9ef8a into master Sep 15, 2022
@gqcn gqcn deleted the enhance/cmd-gen branch September 22, 2022 12:15
houseme pushed a commit to houseme/gf that referenced this pull request Sep 30, 2022
…e` (gogf#2125)

* project template update for command init

* improve command , add extra option �[H�[2J

* add �[H�[2J option for command

* up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants