Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tag value of in support for api definition that has meta info #2450

Merged
merged 4 commits into from
Mar 13, 2023

Conversation

hailaz
Copy link
Member

@hailaz hailaz commented Feb 14, 2023

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: +0.01 🎉

Comparison is base (15d88c2) 79.99% compared to head (84ae67d) 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2450      +/-   ##
==========================================
+ Coverage   79.99%   80.00%   +0.01%     
==========================================
  Files         599      599              
  Lines       49786    49834      +48     
==========================================
+ Hits        39824    39868      +44     
- Misses       8007     8009       +2     
- Partials     1955     1957       +2     
Flag Coverage Δ
go-1.15-386 80.06% <87.50%> (+0.02%) ⬆️
go-1.15-amd64 80.04% <87.50%> (+0.03%) ⬆️
go-1.16-386 80.04% <87.50%> (+0.02%) ⬆️
go-1.16-amd64 80.05% <87.50%> (+0.03%) ⬆️
go-1.17-386 80.05% <87.50%> (+0.05%) ⬆️
go-1.17-amd64 80.05% <87.50%> (+0.05%) ⬆️
go-1.18-386 79.97% <87.50%> (+0.02%) ⬆️
go-1.18-amd64 79.98% <87.50%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
net/ghttp/ghttp_request_param.go 78.44% <ø> (ø)
net/ghttp/ghttp_request_param_request.go 91.17% <87.50%> (+1.01%) ⬆️
os/gfsnotify/gfsnotify_watcher_loop.go 84.87% <0.00%> (-0.85%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

net/ghttp/ghttp_request_param_request.go Outdated Show resolved Hide resolved
@hailaz hailaz added the discuss We need discuss to make decision. label Feb 15, 2023
net/ghttp/ghttp_request_param_request.go Outdated Show resolved Hide resolved
net/ghttp/ghttp_request_param_request.go Outdated Show resolved Hide resolved
net/ghttp/ghttp_request_param_request.go Outdated Show resolved Hide resolved
net/ghttp/ghttp_request_param_request.go Show resolved Hide resolved
@gqcn gqcn changed the title feat: 从标准路由in标签所指定的方式读取参数值 add tag value of in support for api definition that has meta info Feb 16, 2023
@hailaz
Copy link
Member Author

hailaz commented Feb 21, 2023

@gqcn 反射的版本已经改好了

@hailaz hailaz requested a review from gqcn February 22, 2023 10:25
@gqcn gqcn added the wip label Feb 23, 2023
@gqcn gqcn added ready to merge Used in PR, which means this PR is reviewed. and removed discuss We need discuss to make decision. wip labels Mar 2, 2023
@gqcn gqcn merged commit 45e4c9e into master Mar 13, 2023
@gqcn gqcn deleted the feature/param_in branch March 13, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Used in PR, which means this PR is reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants