Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add generic support for http routes registering #2227 #2457 #2807

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Jul 27, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.10% 🎉

Comparison is base (e0e0043) 79.22% compared to head (fe7959e) 79.33%.
Report is 4 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2807      +/-   ##
==========================================
+ Coverage   79.22%   79.33%   +0.10%     
==========================================
  Files         633      633              
  Lines       52242    52403     +161     
==========================================
+ Hits        41391    41575     +184     
+ Misses       8808     8770      -38     
- Partials     2043     2058      +15     
Flag Coverage Δ
go-1.15-386 79.21% <66.66%> (+<0.01%) ⬆️
go-1.15-amd64 79.22% <66.66%> (+0.04%) ⬆️
go-1.16-386 ?
go-1.16-amd64 ?
go-1.17-386 79.23% <66.66%> (+0.02%) ⬆️
go-1.17-amd64 ?
go-1.18-386 79.29% <66.66%> (+0.44%) ⬆️
go-1.18-amd64 79.31% <66.66%> (+0.48%) ⬆️
go-1.19-386 79.10% <66.66%> (-0.12%) ⬇️
go-1.19-amd64 79.12% <66.66%> (-0.09%) ⬇️
go-1.20-386 79.35% <66.66%> (+0.16%) ⬆️
go-1.20-amd64 79.25% <66.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
net/ghttp/ghttp_server_service_handler.go 62.32% <66.66%> (+2.32%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houseme
Copy link
Member

houseme commented Jul 28, 2023

golangci 提示的地方是不是需要处理一下

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Does the place prompted by golangci need to be dealt with?

@gqcn
Copy link
Member Author

gqcn commented Aug 1, 2023

golangci 提示的地方是不是需要处理一下

done

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Does the place prompted by golangci need to be dealt with?

done

Copy link
Member

@houseme houseme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gqcn gqcn merged commit f3437dc into master Aug 2, 2023
27 checks passed
@gqcn gqcn deleted the enhance/generic-routes-support branch August 2, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants