Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gutil.IsSlice judgment logic error #2910

Merged
merged 2 commits into from
Sep 4, 2023
Merged

fix: gutil.IsSlice judgment logic error #2910

merged 2 commits into from
Sep 4, 2023

Conversation

wlynxg
Copy link
Contributor

@wlynxg wlynxg commented Aug 29, 2023

fix: #2855

In the code of gutil.IsSlice, only reflectValue has changed during the loop, and reflectKind has not changed

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (7d4c59a) 79.16% compared to head (fe1bdc8) 79.14%.
Report is 2 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2910      +/-   ##
==========================================
- Coverage   79.16%   79.14%   -0.02%     
==========================================
  Files         638      638              
  Lines       52557    52571      +14     
==========================================
+ Hits        41608    41609       +1     
- Misses       8884     8895      +11     
- Partials     2065     2067       +2     
Flag Coverage Δ
go-1.18-386 79.17% <100.00%> (-0.06%) ⬇️
go-1.18-amd64 79.17% <100.00%> (-0.06%) ⬇️
go-1.19-386 79.12% <100.00%> (+<0.01%) ⬆️
go-1.19-amd64 79.07% <100.00%> (-0.08%) ⬇️
go-1.20-386 79.22% <100.00%> (+<0.01%) ⬆️
go-1.20-amd64 79.19% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/utils/utils_is.go 94.82% <100.00%> (+5.35%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn
Copy link
Member

gqcn commented Aug 31, 2023

@wlynxg 💖 Great! Thanks for your contribution! But would you please add associated unit testing case for this update?

@gqcn gqcn added the wip label Aug 31, 2023
@wlynxg
Copy link
Contributor Author

wlynxg commented Sep 1, 2023

@wlynxg 💖 Great! Thanks for your contribution! But would you please add associated unit testing case for this update?

👌

@gqcn gqcn merged commit 3da5e5e into gogf:master Sep 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] panic with gvar.New(struct).IsSlice()
3 participants