Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change interface ConvertDataForRecord to ConvertValueForField for package gdb #2916

Merged
merged 4 commits into from
Sep 4, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Aug 30, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Patch coverage: 79.08% and project coverage change: +0.02% 🎉

Comparison is base (4dd43aa) 79.16% compared to head (d34295d) 79.18%.
Report is 3 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2916      +/-   ##
==========================================
+ Coverage   79.16%   79.18%   +0.02%     
==========================================
  Files         637      638       +1     
  Lines       52524    52512      -12     
==========================================
+ Hits        41578    41584       +6     
+ Misses       8884     8874      -10     
+ Partials     2062     2054       -8     
Flag Coverage Δ
go-1.18-386 79.26% <79.08%> (+0.07%) ⬆️
go-1.18-amd64 79.26% <79.08%> (+0.03%) ⬆️
go-1.19-386 79.14% <79.08%> (+0.07%) ⬆️
go-1.19-amd64 79.15% <79.08%> (+0.02%) ⬆️
go-1.20-386 79.22% <79.08%> (+0.12%) ⬆️
go-1.20-amd64 79.26% <79.08%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
container/gmap/gmap_hash_str_any_map.go 98.20% <ø> (ø)
database/gdb/gdb.go 68.34% <ø> (ø)
internal/instance/instance.go 100.00% <ø> (ø)
os/gcache/gcache.go 96.77% <ø> (ø)
os/gtime/gtime.go 86.93% <ø> (ø)
text/gregex/gregex_cache.go 100.00% <ø> (ø)
text/gstr/gstr_sub.go 93.47% <ø> (ø)
contrib/drivers/dm/dm.go 69.70% <45.83%> (-0.55%) ⬇️
database/gdb/gdb_core_structure.go 67.17% <71.42%> (-0.63%) ⬇️
contrib/drivers/clickhouse/clickhouse.go 73.75% <75.00%> (-0.59%) ⬇️
... and 10 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn merged commit b9e2b05 into master Sep 4, 2023
18 checks passed
@gqcn gqcn deleted the enhance/field-type branch September 4, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants