Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gjson encode to string expect inconformity(issue 2520) #2928

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fix: gjson encode to string expect inconformity(issue 2520) #2928

merged 1 commit into from
Sep 4, 2023

Conversation

wlynxg
Copy link
Contributor

@wlynxg wlynxg commented Sep 4, 2023

fix: #2520

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (7d4c59a) 79.16% compared to head (1aa0a83) 79.15%.
Report is 2 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2928      +/-   ##
==========================================
- Coverage   79.16%   79.15%   -0.02%     
==========================================
  Files         638      638              
  Lines       52557    52572      +15     
==========================================
+ Hits        41608    41613       +5     
- Misses       8884     8892       +8     
- Partials     2065     2067       +2     
Flag Coverage Δ
go-1.18-386 79.25% <100.00%> (+0.02%) ⬆️
go-1.18-amd64 79.22% <100.00%> (-0.01%) ⬇️
go-1.19-386 79.05% <100.00%> (-0.07%) ⬇️
go-1.19-amd64 79.05% <100.00%> (-0.10%) ⬇️
go-1.20-386 79.21% <100.00%> (-0.01%) ⬇️
go-1.20-amd64 79.19% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
util/gconv/gconv_map.go 96.03% <100.00%> (+0.01%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn merged commit eb11061 into gogf:master Sep 4, 2023
9 checks passed
@gqcn
Copy link
Member

gqcn commented Sep 4, 2023

@wlynxg 👍

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@wlynxg 👍

@wlynxg wlynxg deleted the gjson branch September 15, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gjson encode to string expect inconformity
4 participants