Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance #3063 #3115

Merged
merged 4 commits into from
Nov 6, 2023
Merged

enhance #3063 #3115

merged 4 commits into from
Nov 6, 2023

Conversation

oldme-git
Copy link
Member

@oldme-git oldme-git commented Oct 31, 2023

closed #3063
Please review geo ctrl test First, merge it. Then you can review this PR.

@gqcn
Copy link
Member

gqcn commented Oct 31, 2023

@oldme-git Please add associated unit testing case for this pr.

Copy link
Member

@gqcn gqcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit testing case required.

@oldme-git
Copy link
Member Author

oldme-git commented Oct 31, 2023

@gqcn#3090 合并后,此PR就会有单测

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@gqcn After #3090 is merged, this PR will have a single test

@oldme-git oldme-git requested a review from gqcn November 1, 2023 14:16
@gqcn gqcn merged commit 007fe0e into gogf:master Nov 6, 2023
20 checks passed
@oldme-git oldme-git deleted the enhance/#3063 branch November 6, 2023 09:46
@oldme-git oldme-git linked an issue Feb 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use 'gf gen ctrl' to support“type()” gf gen ctr cannot recognize type struct group definition
3 participants