Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #2924 #3177

Merged
merged 4 commits into from
Dec 21, 2023
Merged

fix: #2924 #3177

merged 4 commits into from
Dec 21, 2023

Conversation

hailaz
Copy link
Member

@hailaz hailaz commented Nov 27, 2023

fix #2924

@gqcn
Copy link
Member

gqcn commented Nov 29, 2023

@hailaz 这个改动挺好的 👍 ，不过能否有时间同时增加一下对应的单测？

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@hailaz This change is very good 👍, but can you have time to add the corresponding single test at the same time?

@hailaz hailaz added the wip label Dec 7, 2023
@hailaz hailaz added done This issue is done, which may be release in next version. and removed wip labels Dec 8, 2023
@gqcn gqcn merged commit 4cce855 into master Dec 21, 2023
42 checks passed
@gqcn gqcn deleted the fix/#2924 branch December 21, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gqcn gqcn gqcn approved these changes

Assignees
No one assigned
Labels
done This issue is done, which may be release in next version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It's invalid : generate pbentity --jsonCase
3 participants
@hailaz @gqcn @Issues-translate-bot