Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dependent redoc js for swagger ui #3217

Merged
merged 13 commits into from
Dec 28, 2023
Merged

Conversation

hailaz
Copy link
Member

@hailaz hailaz commented Dec 19, 2023

No description provided.

@gqcn
Copy link
Member

gqcn commented Dec 19, 2023

@hailaz 不用在swagger js配置上花心思,本来框架提供的swagger就是一个简便的工具,没必要实现的太复杂了,需要自定义Swagger可以参考文档 https://goframe.org/pages/viewpage.action?pageId=47703685

@gqcn gqcn closed this Dec 19, 2023
@gqcn gqcn added the rejected The proposal or PR is not accepted, which might be conflicted with our design or plan. label Dec 19, 2023
@houseme houseme reopened this Dec 21, 2023
@houseme houseme requested a review from gqcn December 21, 2023 09:38
@houseme houseme added ready to merge Used in PR, which means this PR is reviewed. and removed rejected The proposal or PR is not accepted, which might be conflicted with our design or plan. labels Dec 21, 2023
@gqcn
Copy link
Member

gqcn commented Dec 21, 2023

@houseme 要么就升级解决依赖的js问题,要么就自定义ui,增加一个redoc的js配置没啥意义啊,因为html也是和redoc绑定的,换个其他swagger ui也需要换html

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@houseme Either upgrade to solve the dependent js problem, or customize the UI. It makes no sense to add a redoc js configuration, because html is also bound to redoc. If you change other swagger ui, you also need to change html.

@gqcn gqcn changed the title feat: 支持自定义swagger的js路径 feat: update dependent redoc js Dec 21, 2023
@gqcn gqcn changed the title feat: update dependent redoc js feat: update dependent redoc js for swagger ui Dec 21, 2023
@gqcn gqcn removed the ready to merge Used in PR, which means this PR is reviewed. label Dec 21, 2023
@houseme
Copy link
Member

houseme commented Dec 21, 2023

@houseme 要么就升级解决依赖的js问题,要么就自定义ui,增加一个redoc的js配置没啥意义啊,因为html也是和redoc绑定的,换个其他swagger ui也需要换html

添加了可自定义html模板,需要注意json文件的地址替换为:{SwaggerUIDocUrl}

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@houseme Either upgrade to solve the dependent js problem, or customize the UI. There is no point in adding a redoc js configuration, because html is also bound to redoc. If you change other swagger ui, you also need to change html.

Customizable actions added! ! !

houseme and others added 6 commits December 21, 2023 23:24
…swagger-js

* 'feature/swagger-js' of github.com:gogf/gf:
  feat: improve code for swagger and add swagger template
  feat:replace redoc.standalone.js cdn address
  feat: 支持自定义swagger的js路径
  version v2.6.1 (#3222)
@houseme
Copy link
Member

houseme commented Dec 22, 2023

@gqcn

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@gqcn

@gqcn gqcn merged commit 984cca8 into master Dec 28, 2023
42 checks passed
@gqcn gqcn deleted the feature/swagger-js branch December 28, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants