Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contrib/registry/etcd/): add DialTimeout and AutoSyncInterval option #3698

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

fengshunli
Copy link
Member

@fengshunli fengshunli commented Jul 21, 2024

add DialTimeout parameter to prevent the service from blocking the program when it is not started
add AutoSyncInterval fix #3683

@fengshunli fengshunli changed the title add etcd DialTimeout add etcd DialTimeout and AutoSyncInterval Jul 21, 2024
contrib/registry/etcd/etcd.go Outdated Show resolved Hide resolved
contrib/registry/etcd/etcd.go Outdated Show resolved Hide resolved
@gqcn gqcn changed the title add etcd DialTimeout and AutoSyncInterval feat(contrib/registry/etcd/): add etcd DialTimeout and AutoSyncInterval Jul 22, 2024
@gqcn gqcn changed the title feat(contrib/registry/etcd/): add etcd DialTimeout and AutoSyncInterval feat(contrib/registry/etcd/): add DialTimeout and AutoSyncInterval option Jul 22, 2024
@fengshunli
Copy link
Member Author

done

contrib/registry/etcd/etcd.go Show resolved Hide resolved
contrib/registry/etcd/etcd.go Outdated Show resolved Hide resolved
contrib/registry/etcd/etcd.go Show resolved Hide resolved
contrib/registry/etcd/etcd.go Outdated Show resolved Hide resolved
contrib/registry/etcd/etcd.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 14, 2024

contrib/registry/etcd/etcd.go Outdated Show resolved Hide resolved
contrib/registry/etcd/etcd.go Outdated Show resolved Hide resolved
@fengshunli
Copy link
Member Author

fengshunli commented Sep 23, 2024

grpc.WithBlock()默认添加了超时时间,这样不会让程序一直阻塞

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


DialOptions adds a timeout by default, so that the program will not block all the time.

contrib/registry/etcd/etcd.go Outdated Show resolved Hide resolved
@fengshunli
Copy link
Member Author

done @gqcn

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


done @gqcn

@gqcn gqcn merged commit a1ce97e into gogf:master Sep 24, 2024
28 checks passed
houseme added a commit that referenced this pull request Sep 28, 2024
…ris-config

* 'master' of github.com:gogf/gf: (23 commits)
  build(go.mod): upgrade minimum required go version from 1.18 to 1.20 (#3688)
  refactor(net/ghttp): enhance `ghttp.StartPProfServer` (#3555)
  refactor(encoding/gjson): change data parameter from type any to []byte (#3542)
  refactor(net/gudp): improve implements (#3491)
  fix(os/gcache): memory leak for LRU when adding operations more faster than deleting (#3823)
  fix(os/gcmd): argument index calculating error in multilevel command (#3807)
  fix(database/gdb): invalid order by statement generated when multiple order inputs (#3803)
  fix(cmd/gf): creating logic.go empty folder when there is no correct logic service (#3815)
  test(drivers/mysql): loose unit testing for transaction (#3819)
  fix(net/ghttp&gclient,contrib/rpc/grpcx): remove request and response contents in opentelemetry tracing attributes (#3810)
  feat: new version v2.7.4 (#3809)
  fix(util/gconv): unstable converting when there is an external attribute with the same name as the internal structure (#3799)
  feat(database/gdb): add year field type support for ORM operations (#3805)
  fix(cmd/gf): table and field names converted to its lower case before CamelCase converting in command `gen dao` (#3801)
  fix(net/gclient): panic when containing `@file:` parameter value in json post request (#3775)
  feat(contrib/registry/etcd/): add `DialTimeout` and `AutoSyncInterval` option (#3698)
  fix(database/gdb): support OrderRandom feature in different databases (#3794)
  fix(net/goai): change default value of RequestBody.Required from true to false, add required tag support for RequestBody (#3796)
  fix(util/gvalid): retrive empty slice parameter in custom validation rule function failed (#3795)
  fix(util/gconv): cached field indexes append issue caused incorrect field converting (#3790)
  ...

# Conflicts:
#	.github/workflows/ci-main.sh
#	.github/workflows/golangci-lint.yml
#	contrib/metric/otelmetric/go.mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contrib/registry/etcd: etcd will not re-register if it is disconnected
3 participants