Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(net/ghttp): skip common response body in common response handler for streaming content types #3762

Merged
merged 4 commits into from
Sep 12, 2024
Merged

fix(net/ghttp): skip common response body in common response handler for streaming content types #3762

merged 4 commits into from
Sep 12, 2024

Conversation

wwwfeng
Copy link
Contributor

@wwwfeng wwwfeng commented Sep 9, 2024

It optimizes the middleware by skipping custom response body handling for streaming content types, preventing unnecessary processing.

@wwwfeng wwwfeng changed the title fix: skip custom body for streaming content types fix(net/ghttp/)fix: skip custom body for streaming content types Sep 9, 2024
@wwwfeng wwwfeng changed the title fix(net/ghttp/)fix: skip custom body for streaming content types fix(net/ghttp/): skip custom body for streaming content types Sep 9, 2024
gqcn
gqcn requested changes Sep 10, 2024
View reviewed changes
net/ghttp/ghttp_middleware_handler_response.go Outdated Show resolved Hide resolved
net/ghttp/ghttp_middleware_handler_response.go Outdated Show resolved Hide resolved
net/ghttp/ghttp_middleware_handler_response.go Show resolved Hide resolved
net/ghttp/ghttp_middleware_handler_response.go Outdated Show resolved Hide resolved
@wwwfeng
1.test: add test case
00b5d11 
2.refactor: improve code readability
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
22.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@gqcn gqcn changed the title fix(net/ghttp/): skip custom body for streaming content types fix(net/ghttp): skip common response body for streaming content types Sep 12, 2024
@gqcn gqcn changed the title fix(net/ghttp): skip common response body for streaming content types fix(net/ghttp): skip common response body in common response handler for streaming content types Sep 12, 2024
@gqcn gqcn merged commit 3d63ebf into gogf:master Sep 12, 2024
23 of 24 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gqcn gqcn gqcn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwwfeng @gqcn