Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Credentials as options on Google Cloud Storage package #81

Conversation

kanisiuskenneth
Copy link
Contributor

Enable users to use Google ADC(Application Default Credentials) to authenticate with Google Cloud Storage.

@kanisiuskenneth kanisiuskenneth added the enhancement New feature or request label Sep 25, 2023
@kanisiuskenneth kanisiuskenneth self-assigned this Sep 25, 2023
pkg/storage/gcs/hystrix.go Outdated Show resolved Hide resolved
pkg/storage/gcs/options.go Outdated Show resolved Hide resolved
@kanisiuskenneth kanisiuskenneth changed the title feat: add UseDefaultCredential toggle to enable usage of default credentials for gcloud storage feat: add Credentials as optiions on Google Cloud Storage package Oct 2, 2023
@kanisiuskenneth kanisiuskenneth changed the title feat: add Credentials as optiions on Google Cloud Storage package feat: add Credentials as options on Google Cloud Storage package Oct 2, 2023
@kanisiuskenneth kanisiuskenneth merged commit cd57945 into gojek:master Oct 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants