Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: replace io/ioutil with io and os package #3

Closed
wants to merge 1 commit into from
Closed

all: replace io/ioutil with io and os package #3

wants to merge 1 commit into from

Conversation

cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Sep 14, 2022 •
edited
Loading

@gopherbot
Copy link
Contributor

This PR (HEAD: c06d884) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/benchmarks/+/430856 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/430856.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430856.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430856.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Meng Zhuo:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430856.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430856.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from shuang cui:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430856.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 3: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430856.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from shuang cui:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430856.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 6a58019) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/benchmarks/+/430856 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 4: Run-TryBot+1 Auto-Submit+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430856.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430856.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/430856.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 19, 2022
@cuishuang @gopherbot
all: replace io/ioutil with io and os package
fdd6c4b 
For golang/go#45557

Change-Id: Ib1e5d3116f04adaacb4d6b81898db255b3d5bd04
GitHub-Last-Rev: 6a58019
GitHub-Pull-Request: #3
Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/430856
Auto-Submit: Ian Lance Taylor <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/430856 has been merged.

@gopherbot gopherbot closed this Sep 19, 2022
DarrylWong pushed a commit to DarrylWong/go-benchmarks that referenced this pull request Apr 22, 2024
Create change
9490607 
Uploaded patch set 1.
This Gerrit CL corresponds to GitHub PR golang/benchmarks#3.

Author: cui fliter <[email protected]>

Patch-set: 1
Patch-set-description: This Gerrit CL corresponds to GitHub PR golang/benchmarks#3. Author: cui fliter <[email protected]>
Change-id: Ib1e5d3116f04adaacb4d6b81898db255b3d5bd04
Subject: all: replace io/ioutil with io and os package
Branch: refs/heads/master
Status: new
Topic: 
Commit: 7b933b7
Tag: autogenerated:gerrit:newPatchSet
Groups: 7b933b7
CC: Gerrit User 51518 <51518@62eb7196-b449-3ce5-99f1-c037f21e1705>
Private: false
Work-in-progress: false
DarrylWong pushed a commit to DarrylWong/go-benchmarks that referenced this pull request Apr 22, 2024
@cuishuang @LetsUseGerrit
all: replace io/ioutil with io and os package
c50a42d 
For #45557

Change-Id: Ib1e5d3116f04adaacb4d6b81898db255b3d5bd04
GitHub-Last-Rev: c06d8841f4cde9ece65ac765dd035dd52bde3a63
GitHub-Pull-Request: golang/benchmarks#3
DarrylWong pushed a commit to DarrylWong/go-benchmarks that referenced this pull request Apr 22, 2024
@cuishuang @LetsUseGerrit
all: replace io/ioutil with io and os package
b271b7a 
For golang/go#45557

Change-Id: Ib1e5d3116f04adaacb4d6b81898db255b3d5bd04
GitHub-Last-Rev: 6a580196cbdc8703799604a59e474f357e2a98e6
GitHub-Pull-Request: golang/benchmarks#3
DarrylWong pushed a commit to DarrylWong/go-benchmarks that referenced this pull request Apr 22, 2024
@cuishuang @LetsUseGerrit
all: replace io/ioutil with io and os package
7b933b7 
Change-Id: Ib1e5d3116f04adaacb4d6b81898db255b3d5bd04
GitHub-Last-Rev: c06d8841f4cde9ece65ac765dd035dd52bde3a63
GitHub-Pull-Request: golang/benchmarks#3
DarrylWong pushed a commit to DarrylWong/go-benchmarks that referenced this pull request Apr 22, 2024
@cuishuang @LetsUseGerrit
all: replace io/ioutil with io and os package
66cf30c 
For golang/go#45557

Change-Id: Ib1e5d3116f04adaacb4d6b81898db255b3d5bd04
GitHub-Last-Rev: c06d8841f4cde9ece65ac765dd035dd52bde3a63
GitHub-Pull-Request: golang/benchmarks#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuishuang @gopherbot