Skip to content

Commit

Permalink
internal/relui, internal/task: clean up after the 1.19 off-cycle release
Browse files Browse the repository at this point in the history
Fixes golang/go#62076.

Change-Id: I682edd67d5274f5d2b7da64d408319b89c6cfeec
Reviewed-on: https://go-review.googlesource.com/c/build/+/526216
Reviewed-by: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
  • Loading branch information
dmitshur authored and gopherbot committed Sep 6, 2023
1 parent 245708a commit 27ac909
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion internal/relui/workflows.go
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,6 @@ func registerProdReleaseWorkflows(ctx context.Context, h *DefinitionHolder, buil
{currentMajor + 1, task.KindBeta, "next beta"},
{currentMajor, task.KindMinor, "next minor"}, // Current minor only.
{currentMajor - 1, task.KindMinor, "next minor"}, // Previous minor only.
{currentMajor - 2, task.KindMinor, "next minor"}, // TODO(go.dev/issue/62076): Remove after Go 1.19.13 is out.
}
if time.Since(majorReleaseTime) < 7*24*time.Hour {
releases = append(releases, release{currentMajor, task.KindMajor, "final"})
Expand Down
5 changes: 0 additions & 5 deletions internal/task/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,6 @@ func (t *VersionTasks) GenerateVersionFile(_ *workflow.TaskContext, distpack boo

// CreateAutoSubmitVersionCL mails an auto-submit change to update VERSION file on branch.
func (t *VersionTasks) CreateAutoSubmitVersionCL(ctx *workflow.TaskContext, branch, version string, reviewers []string, versionFile string) (string, error) {
// TODO(go.dev/issue/62076): Remove after Go 1.19.13 is out.
if branch == "release-branch.go1.19" && version == "go1.19.13" {
return "go~526138", nil // Use the CL it already created (but failed to add votes/reviewers to).
}

return t.Gerrit.CreateAutoSubmitChange(ctx, gerrit.ChangeInput{
Project: t.GoProject,
Branch: branch,
Expand Down
1 change: 0 additions & 1 deletion internal/task/version_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ func TestGetNextVersionLive(t *testing.T) {
{currentMajor + 1, KindBeta}, // Next beta.
{currentMajor, KindMinor}, // Current minor only.
{currentMajor - 1, KindMinor}, // Previous minor only.
{currentMajor - 2, KindMinor}, // TODO(go.dev/issue/62076): Remove after Go 1.19.13 is out.
} {
v, err := tasks.GetNextVersion(ctx, tc.major, tc.kind)
if err != nil {
Expand Down

0 comments on commit 27ac909

Please sign in to comment.