Skip to content

Commit

Permalink
internal/task: don't check blockers for RC releases
Browse files Browse the repository at this point in the history
I missed a quirk of logic in releasebot.

For golang/go#51797.

Change-Id: I8f1fd9f4af4ae6743d7d874b5223b45fd9127c96
Reviewed-on: https://go-review.googlesource.com/c/build/+/416219
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Heschi Kreinick <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Heschi Kreinick <[email protected]>
  • Loading branch information
heschi authored and gopherbot committed Jul 7, 2022
1 parent 8c4a1e1 commit 3bb68c2
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions internal/task/milestones.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ func uppercaseVersion(version string) string {
// CheckBlockers returns an error if there are open release blockers in
// the current milestone.
func (m *MilestoneTasks) CheckBlockers(ctx *workflow.TaskContext, milestones ReleaseMilestones, version string, kind ReleaseKind) error {
if kind == KindRC {
// We don't check blockers for release candidates; they're expected to
// at least have recurring blockers, and we don't have an okay-after
// label to suppress them.
return nil
}
issues, err := m.loadMilestoneIssues(ctx, milestones.Current, kind)
if err != nil {
return err
Expand Down

0 comments on commit 3bb68c2

Please sign in to comment.