Add support for downloading through a proxy #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for the PR! Unfortunately, the Go project doesn't use GitHub's Pull Requests, The good news is, I'm here to help. From here, you have two options:
I'm going to close this Pull Request now. Thanks again, GopherBot (on behalf of the Go Team) |
|
Sent https://go-review.googlesource.com/35845 instead. Thanks! |
|
Thanks! I'll get set up with Gerrit for next time. |
gopherbot
pushed a commit
that referenced
this pull request
Jul 20, 2017
… issues Some CLs may refer to recently closed issues (e.g., fixups or followups). It'd be better if @gopherbot would post the usual "CL nnnn mentions this issue." comment in those situations. Currently, the bot skips all closed issues when considering posting that message. This was done to avoid posting in really old, frozen issues (e.g., #1, #2, etc.) when they're accidentally referenced. However, a better proxy is to check whether the issue has the FrozenDueToAge label, which the bot automatically applies to old issues that are closed (see gopherbot.freezeOldIssues). Fixes golang/go#21106. Change-Id: If7489e8c001180944c47a0205909aa4043693436 Reviewed-on: https://go-review.googlesource.com/50470 Reviewed-by: Matt Layher <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]> Run-TryBot: Matt Layher <[email protected]>
gopherbot
pushed a commit
that referenced
this pull request
Aug 18, 2023
TestGetNextVersion/#00, TestGetNextVersion/#1 and so on wasn't quite what I had in mind in CL 520238. Also simplify the -test.run flag value lookup while here. The type we want is a string, so no need for flag.Getter. For golang/go#62076. Change-Id: Ie1d8125caa5f6bf4fc53e3fd9e8807dbf9608384 Reviewed-on: https://go-review.googlesource.com/c/build/+/520355 Run-TryBot: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I work behind a corporate proxy, which isn't supported by the build tool, so I am unable to test the RCs of the next version of Go.
This adds support for reading proxy setup from the standard environment variables.