reflect: panic if MakeSlice is given bad len/cap arguments.

Fixes #3330. R=golang-dev, r CC=golang-dev https://golang.org/cl/5847043
golang · Mar 16, 2012 · 11cc5a2 · 11cc5a2
1 parent 8009542
commit 11cc5a2
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/pkg/reflect/value.go b/src/pkg/reflect/value.go
@@ -1632,6 +1632,15 @@ func MakeSlice(typ Type, len, cap int) Value {
  if typ.Kind() != Slice {
  panic("reflect.MakeSlice of non-slice type")
  }
+ if len < 0 {
+ panic("reflect.MakeSlice: negative len")
+ }
+ if cap < 0 {
+ panic("reflect.MakeSlice: negative cap")
+ }
+ if len > cap {
+ panic("reflect.MakeSlice: len > cap")
+ }
 
  // Declare slice so that gc can see the base pointer in it.
  var x []byte