Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5c, 5g, 8c, 8g: make 64-bit fields 64-bit aligned #3799

Closed
dvyukov opened this issue Jul 4, 2012 · 5 comments
Closed

5c, 5g, 8c, 8g: make 64-bit fields 64-bit aligned #3799

dvyukov opened this issue Jul 4, 2012 · 5 comments
Milestone

Comments

@dvyukov
Copy link
Member

dvyukov commented Jul 4, 2012

64-bit load/store functions on 386 assume that the addr is 64-bit aligned, but 8g does
not ensure that.
See also issue https://golang.org/issue/3798
@rsc
Copy link
Contributor

rsc commented Aug 3, 2012

Comment 1:

5c, 5g, 8c, 8g: make 64-bit fields 64-bit aligned
This is necessary for atomics to work correctly.

Labels changed: added priority-soon, removed priority-triage.

Owner changed to @rsc.

@minux
Copy link
Member

minux commented Aug 6, 2012

Comment 2:

do we need to increase Structrnd and maxround from sizeof(uintptr) to 8 also?

@rsc
Copy link
Contributor

rsc commented Sep 12, 2012

Comment 3:

Issue #3798 has been merged into this issue.

@rsc
Copy link
Contributor

rsc commented Sep 12, 2012

Comment 4:

Status changed to Duplicate.

Merged into issue #599.

@rsc
Copy link
Contributor

rsc commented Sep 12, 2012

Comment 5:

Labels changed: added go1.1.

@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc removed their assignment Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants