Allow parsing a straight EXIF buffer instead of requiring an image #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypically I think this number is 6)
Pull in DougReeder's changes
This is useful for scenarios where another library is parsing the EXIF data.
Well, it was probably busted for all cases, but I'm not sure if that's true. basically, the != 0x00000000 test was broken. So, as long as there as an IFD1 offset, the code worked fine.
…mfunkel-master Conflicts: lib/exif/Buffer.js lib/exif/ExifImage.js lib/exif/makernotes/agfa.js lib/exif/makernotes/epson.js lib/exif/makernotes/olympus.js
I'm not sure exactly what the spec requires, but an offset of 0 seems like a really odd choice for an IFD pointer in an exif block. In any case, it was wrong in this particular file and other examples i can find.
|
I just added another commit which fixes a bug if a file has a GPSInfo IFD entry with a value of 0. 0 doesn't make any sense, if I'm reading the spec correctly, so I explicitly check for > 0 in this commit. If anyone is more of an expert on this, please correct me, but it seems like this might be a good sanity check for all the IFD pointers that are offset from the header. |
|
Thanks for the pull request, looks like some nice stuff in there! I checked some of the changes and realized that I can't merge everything automatically. I will see to merge everything in the next couple of days. |
|
@gomfunkel cool - let me know if you need anything from my end. Happy to help if I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. This pull request looks big, but it really isn't - there are a lot of whitespace changes that cloud the default diff view.
Two major changes:
Let me know if you have any comments or concerns. I had a long-ago-forked version that I remerged your master into and brought back into line. I don't think any other changes crept in (they were mostly bug fixes from other pull requests that you've since merged).