fix(pkg/stash): don't check status of all etcd endpoints on start #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Athens checks the status of all etcd endpoints when started, which can cause issues when some members of the etcd cluster are unavailable. It is perfectly okay for some members of an etcd cluster to be unavailable, as it's designed for high availability and fault tolerance. The management of the connections is instead deferred to the etcd client, which will handle failures and load balancing as expected. Fixes: gomods#1888
|
@manugupt1 Would it be possible to merge this one? It makes rolling deployments really painful. ❯ k -n athens get po
NAME READY STATUS RESTARTS AGE
athens-7567c44545-57ncd 0/1 CrashLoopBackOff 3 (37s ago) 112s
athens-7567c44545-bds65 0/1 CrashLoopBackOff 3 (43s ago) 112s
athens-7567c44545-vttm6 0/1 CrashLoopBackOff 3 (43s ago) 112s
athens-7df4f68c45-9m9jw 1/1 Running 0 42m
athens-7df4f68c45-kcg5l 1/1 Running 4 (42m ago) 43m
athens-7df4f68c45-pnsk9 1/1 Running 4 (42m ago) 43m
athens-7df4f68c45-qjjtz 1/1 Running 0 42m
athens-etcd-0 1/1 Running 0 65s
athens-etcd-1 1/1 Running 0 88s
athens-etcd-2 1/1 Running 0 110s |
manugupt1
approved these changes
Sep 18, 2023
|
Thank you @manugupt1 😄 |
kmuchmore
pushed a commit
to kmuchmore/athens
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Athens checks the status of all etcd endpoints when started, which can cause issues when some members of the etcd cluster are unavailable. It is perfectly okay for some members of an etcd cluster to be unavailable, as it's designed for high availability and fault tolerance.
How is the fix applied?
The management of the connections is instead deferred to the etcd client, which will handle failures and load balancing as expected.
What GitHub issue(s) does this PR fix or close?
Fixes: #1888