Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Model dataclass #439

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

rozha
Copy link
Contributor

@rozha rozha commented Jul 7, 2024

Dataclass Model misses max_temperature field which brakes list_models()

Description of the change

Fix Model dataclass with adding max_temperature field

Motivation

list_models() doesn't work without max_temperature

Type of change

Bug fix

Checklist

  • [+ ] I have performed a self-review of my code.
  • [ +] I have added detailed comments to my code where applicable.
  • [ +] I have verified that my change does not break existing code.
  • [ +] My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • [ +] I am familiar with the Google Style Guide for the language I have coded in.
  • [ +] I have read through the Contributing Guide and signed the Contributor License Agreement.

Dataclass Model misses max_temperature field which brakes list_models()
Copy link

google-cla bot commented Jul 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Jul 7, 2024
Change-Id: I0cdacd0134c868044ae5b96322b266224d7b8a69
MarkDaoust
MarkDaoust previously approved these changes Jul 8, 2024
@MarkDaoust
Copy link
Collaborator

#426

Change-Id: I5db22405c93b66fd268b19f1e081dc24f3246d24
@MarkDaoust
Copy link
Collaborator

Thanks!

@MarkDaoust MarkDaoust merged commit 85ee8c1 into google-gemini:main Jul 8, 2024
7 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants