Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async for files.py functions #586

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shilpakancharla
Copy link
Collaborator

Added asyncio methods for all the file methods.

However, how should we test these asyncio methods?

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Oct 5, 2024
Copy link

@ratchanonsuttawas ratchanonsuttawas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review these changes 3c3c661

@ratchanonsuttawas

This comment was marked as spam.

@ratchanonsuttawas

This comment was marked as spam.

@ratchanonsuttawas

This comment was marked as spam.

Copy link

@ratchanonsuttawas ratchanonsuttawas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve these changes

Copy link

@ratchanonsuttawas ratchanonsuttawas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A review is request

@ratchanonsuttawas

This comment was marked as spam.

@ratchanonsuttawas

This comment was marked as spam.

@ratchanonsuttawas

This comment was marked as spam.

@ratchanonsuttawas

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants