Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document most common ExoPlaybackException causes #1611

Closed
laurafuente opened this issue Jun 21, 2016 · 6 comments
Closed

Document most common ExoPlaybackException causes #1611

laurafuente opened this issue Jun 21, 2016 · 6 comments
Assignees

Comments

@laurafuente
Copy link

My request is to set a more intelligent error management instead of always launching a ExoPlaybackException. This makes very difficult to shown information to the user about the player error.
The ideal solution was to return different error codes for different errors to know the cause of the error

@andrewlewis
Copy link
Collaborator

andrewlewis commented Jun 21, 2016

Does the cause returned by e.getCause() contain the information you need? (See the javadoc for ExoPlaybackException.)

@laurafuente
Copy link
Author

Hi Andrew, with the cause I can get some information in some cases surfing the code. But probably it's more user friendly to have a list with the different kinds of errors I can get from the player.

@andrewlewis
Copy link
Collaborator

As per #1552, it's not possible to provide a complete list of errors, but I agree it would be useful to have documentation listing the most common/important exceptions. I'll use this issue to track adding the documentation. Thanks!

@andrewlewis andrewlewis self-assigned this Jun 21, 2016
@andrewlewis andrewlewis changed the title Error management improvement Document most common ExoPlaybackException causes Jun 21, 2016
@laurafuente
Copy link
Author

Hi,
Let me know when that documentation is available, please
Thanks Andrew

@andrewlewis
Copy link
Collaborator

It's been a while, but one way to address this finally would be to implement a more comprehensive ErrorMessageProvider, like the one in the demo app.

icbaker pushed a commit that referenced this issue Jul 21, 2021
#minor-release
Issue: #1611
PiperOrigin-RevId: 385741535
@ojw28
Copy link
Contributor

ojw28 commented Aug 9, 2021

This will be addressed by PlaybackException.errorCode in 2.15.

@ojw28 ojw28 closed this as completed Aug 9, 2021
@google google locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants