-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect parsing of UTF-16 in ID3 frames #1774
Labels
Comments
Thanks for reporting this; we'll push a fix to V1 and V2 shortly. |
ojw28
added a commit
that referenced
this issue
Aug 31, 2016
Issue: #1774 ------------- Created by MOE: https:/google/moe MOE_MIGRATED_REVID=131389528
ojw28
added a commit
that referenced
this issue
Aug 31, 2016
Issue: #1774 ------------- Created by MOE: https:/google/moe MOE_MIGRATED_REVID=131389528
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The end of string detection (introduced for issue 324) looks for a pair of zero bytes. It should look for a pair of zero bytes starting at an even index, otherwise it will incorrectly parse a string whose last character encoding ends with a 0 byte.
Suggested change to
Id3Parser.indexOfEos
:The text was updated successfully, but these errors were encountered: