Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdaptiveVideoTrackSelection Class is used both for Video and Audio Tracks #2257

Closed
giladna opened this issue Dec 25, 2016 · 4 comments
Closed

Comments

@giladna
Copy link

giladna commented Dec 25, 2016

Hi,
It will be better to give that class more generic name maybe

10x
Gilad

@ojw28
Copy link
Contributor

ojw28 commented Jan 2, 2017

I don't think it is used for audio tracks in any default configuration. It's also not well suited to audio adaptation; and if audio adaptation is desired a different implementation would probably be preferable. Please clarify and point out the circumstances in which it is used for audio tracks if you think this is incorrect.

@ojw28
Copy link
Contributor

ojw28 commented Jan 4, 2017

Closing due to lack of information.

@ojw28 ojw28 closed this as completed Jan 4, 2017
@giladna
Copy link
Author

giladna commented Jan 5, 2017

Hi Olly,

This is used in also in Audio Tracks
In case you have bitrates selection capability for audio quality

When I come to check the Auto bitrate for AUDIO
I get the instance of AdaptiveVideoTrackSelection

@ojw28
Copy link
Contributor

ojw28 commented Jan 5, 2017

I'm not convinced that actually happens. There's another issue here that says, I think correctly, that audio isn't adaptive by default. If there are multiple audio tracks then current behavior is to pick one and stick with it. The default track selector only ever selects a fixed track for audio here.

Can you provide an example of a stream where, if added to the demo app, performs an adaptive audio playback?

@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants