Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flac extension cause crash of released app #2427

Closed
Fed93 opened this issue Feb 7, 2017 · 5 comments
Closed

Flac extension cause crash of released app #2427

Fed93 opened this issue Feb 7, 2017 · 5 comments
Assignees

Comments

@Fed93
Copy link

Fed93 commented Feb 7, 2017

I've compiled and added the flac extension successful.
I've added the extension as a module in my app!

If i install app on my phone in debug it works great but if i compile to release it to the playstore, app crash when i try to reproduce flac song.

I use proguard provided with extension and proguard for main app (attached)
I'm using latest version of the extension adding -DHAVE_SYS_PARAM_H to LOCAL_CFLAGS in order to compile with latest ndk and ExoPlayer r2.2.0 on Samsung Galaxy S6.

Link to Flac Media: https://drive.google.com/open?id=0B4IKkuWtSFhkX2lyazEzcENCdzQ
Logs & ProGuard.zip

@erdemguven
Copy link
Contributor

@Fed93 please add this to the flac extension proguard file (extensions/flac/src/main/proguard-rules.txt):

-keep class com.google.android.exoplayer2.util.FlacStreamInfo {
    *;
}

and try again.

@Fed93
Copy link
Author

Fed93 commented Feb 8, 2017

Yes, works great adding it to Proguard!
Thank you very much!

Only a question it's normal that FLAC song it's not seekable?

@erdemguven
Copy link
Contributor

erdemguven commented Feb 9, 2017

Good, soon a fix for it will be committed.

Unfortunately we don't support seeking if the flac file doesn't contain an seek table. See #1808

@Fed93
Copy link
Author

Fed93 commented Feb 9, 2017

Thank you very much!

@ojw28
Copy link
Contributor

ojw28 commented Feb 15, 2017

Reopening until fix is merged.

ojw28 pushed a commit that referenced this issue Feb 15, 2017
Issue: #2427

-------------
Created by MOE: https:/google/moe
MOE_MIGRATED_REVID=146905629
@ojw28 ojw28 closed this as completed Feb 20, 2017
@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants