-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smooth Streaming {start_time} placeholder not supported #2447
Labels
Comments
We should also match both {bitrate} and {Bitrate} according to the spec, rather than just {bitrate} as we do currently. We'll push a fix shortly. |
ojw28
added a commit
that referenced
this issue
Feb 15, 2017
Issue: #2447 ------------- Created by MOE: https:/google/moe MOE_MIGRATED_REVID=147358615
ojw28
added a commit
that referenced
this issue
Mar 16, 2017
Issue: #2447 ------------- Created by MOE: https:/google/moe MOE_MIGRATED_REVID=147358615
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Exoplayer 2.2.0
Device: Nexus player
Android 7.1.1
Exoplayer is not working with some Smooth Streaming manifests.
That's happening when the
Url
for aStreamIndex
has a placeholder for the start time with the format:"start_time"
instead of"start time"
(with an underscore between start and time).Example:
<StreamIndex Type="audio" QualityLevels="3" TimeScale="10000000" Language="eng" Name="audio_eng" Chunks="1378" Url="QualityLevels({bitrate})/Fragments(audio_eng={start_time})">
SsManifest.java
Placeholder defined as:
private static final String URL_PLACEHOLDER_START_TIME = "{start time}";
The method
buildRequestUri()
is only replacing"start time"
, but not"start_time"
Then, the placeholder remains in the Url, causing an error response.
The text was updated successfully, but these errors were encountered: