-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DefaultTimeBar depends on onLayout to update playhead position #2871
Labels
Comments
To fix this I think you could just put |
ojw28
pushed a commit
that referenced
this issue
May 31, 2017
Issue: #2871 ------------- Created by MOE: https:/google/moe MOE_MIGRATED_REVID=157562792
ojw28
pushed a commit
that referenced
this issue
Jun 6, 2017
Issue: #2871 ------------- Created by MOE: https:/google/moe MOE_MIGRATED_REVID=157562792
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Issue description
DefaultTimeBar doesn't update the playhead position if exo_position and exo_duration have fixed widths.
This is a result of DefaultTimeBar only updating the playhead position when onLayout is called. This works correctly in the demo app, as when the position text is updated it needs to re-measure the view.
Reproduction steps
Set the following attribute on R.id.exo_position and R.id.exo_duration in the demo app:
android:ems="6"
Result: DefaultTimeBar's playhead doesn't move since onLayout is only called once.
Link to test content
Any content in the demo app will do.
Version of ExoPlayer being used
2.4.1
Device(s) and version(s) of Android being used
Tested on Nexus 5X Android 7.1.2, though I'm sure this behaviour is common across all API levels + devices.
A full bug report captured from the device
bugreport-N2G47O-2017-05-26-22-19-07.zip
The text was updated successfully, but these errors were encountered: