-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suspicious null in method overload #4403
Labels
Comments
That looks indeed suspicious. @erdemguven Can you take a look? |
My bad in a0b1559. I'll make a fix to use the passed in flag. Thanks for reporting this. |
ojw28
pushed a commit
that referenced
this issue
Jun 22, 2018
Issue: #4403 ------------- Created by MOE: https:/google/moe MOE_MIGRATED_REVID=201525284
ojw28
pushed a commit
that referenced
this issue
Jun 25, 2018
Issue: #4403 ------------- Created by MOE: https:/google/moe MOE_MIGRATED_REVID=201525284
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In overloaded
cache
method instead of passing@Nullable AtomicBoolean isCanceled
argument this method just passesnull
next. So now modifying the AtomicBoolean doesn't cancel the caching.ExoPlayer/library/core/src/main/java/com/google/android/exoplayer2/upstream/cache/CacheUtil.java
Line 135 in 000f3f2
The text was updated successfully, but these errors were encountered: