Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NON IDR frames VIDEOS playing with alot of PIXELS on exoplayer #4951

Closed
littlelitleStar opened this issue Oct 13, 2018 · 8 comments
Closed
Assignees
Labels

Comments

@littlelitleStar
Copy link

I had a problem that EXO player wasnt playing non IDR frames videos, but i fixed it by adding the "FLAG_ALLOW_NON_IDR_KEYFRAMES" FLAG.

Afer adding that, Channels are playing good. But then i saw that those NON IDR KEYFRAME channels , are playing good in MOBILE SCREEN, but in Android boxes and Emulators like bluestacks. Its playing the video with a lot of pixels. Like this PHOTO. taken from an example

image

Does anyone knows how to fix it. ?

Thank you

@andrewlewis
Copy link
Collaborator

Setting FLAG_ALLOW_NON_IDR_KEYFRAMES makes the player assume that all I-frames are synchronization points, but this assumption is not valid for all cases. This is probably an example of a stream where I-frames are not all synchronization points.

I think @AquilesCanta had a plan to handle some additional signaling for synchronization points via particular SEI NAL units, which might help, but it hasn't been implemented yet. We may want to mark this as an enhancement to support that if there's no existing issue.

@littlelitleStar
Copy link
Author

Can we figure out any solution about this ?

@littlelitleStar
Copy link
Author

The Thing that drives me crazy is that , On my mobile PHONE ,is working perfectly..

But on Android Boxes and Emulators , You cant watch them ,, too many PIXELS. image is too bad

@AquilesCanta
Copy link
Contributor

I am not 100% sure that the SEI handling will help your issue, @psycomani. There is not much we can do about this, unfortunately. We don't have the time to properly investigate this right now.

@AquilesCanta
Copy link
Contributor

Let's use #2841 to track handling of SEI recovery points. I cannot think of a solution for the device-specific decoding issue, though.

@littlelitleStar
Copy link
Author

@AquilesCanta Ithink its a problem of DECODING the image.

I dont know why but in Android BOXES , and EMULATORS its not working.

But in PHONES ( small screen ) , its working perfectly ?

@AquilesCanta
Copy link
Contributor

Yes, I understand, but I don't have the bandwidth to investigate this, unfortunately. First, I'll try to implement support for SEI recovery points. After that, we can see whether ExoPlayer can do something about this.

@AquilesCanta
Copy link
Contributor

Actually, I'll close this issue. Please track #2841 and once support is pushed, give it a try. If rendering is still not working correctly, please file a new issue including all the information in the issue template.

ojw28 pushed a commit that referenced this issue Dec 18, 2018
Use random access indicator in transport streams

Issue:#1967
Issue:#2020
Issue:#2182
Issue:#2469
Issue:#2581
Issue:#2748
Issue:#2939
Issue:#2979
Issue:#3316
Issue:#3574
Issue:#3709
Issue:#3747
Issue:#4103
Issue:#4184
Issue:#4355
Issue:#4538
Issue:#4719
Issue:#4861
Issue:#4925
Issue:#4951
Issue:#5108
Issue:#5186
PiperOrigin-RevId: 225798044
ojw28 pushed a commit that referenced this issue Dec 19, 2018
Use random access indicator in transport streams

Issue:#1967
Issue:#2020
Issue:#2182
Issue:#2469
Issue:#2581
Issue:#2748
Issue:#2939
Issue:#2979
Issue:#3316
Issue:#3574
Issue:#3709
Issue:#3747
Issue:#4103
Issue:#4184
Issue:#4355
Issue:#4538
Issue:#4719
Issue:#4861
Issue:#4925
Issue:#4951
Issue:#5108
Issue:#5186
PiperOrigin-RevId: 225798044
@google google locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants