-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImaAdsLoader leaks AdEventListener within its AdsManager #6687
Labels
Comments
We call If that's not the case then we should probably remove the listeners in addition to calling |
marcbaechinger
pushed a commit
that referenced
this issue
Dec 4, 2019
Issue: #6687 PiperOrigin-RevId: 283023548
ojw28
pushed a commit
that referenced
this issue
Dec 6, 2019
Issue: #6687 PiperOrigin-RevId: 283023548
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Not sure if this is intentional or not, or whether I'm just using the API incorrectly, but I noticed that the value given to
ImaAdsLoader.Builder.setAdEventListener(AdEventListener)
never gets removed from theAdsManager
instance it owns. The consequence of this in my app is where if I'm playing an ad, then callImaAdsLoader.release()
theImaAdsLoader
'sAdsManager
still holds onto myAdEventListener
and sends it anAdEvent
with typeAdEventType.CONTENT_RESUME_REQUESTED
, which I don't want (I would've expectedImaAdsLoader.release()
to remove theAdEventListener
I gave it during instantiation, for me).There's no method that I'm aware of on
ImaAdsLoader
to remove myAdEventListener
, so as a workaround I have to tap intoImaAdsLoader.getAdsLoader().addAdsLoadedListener(...)
then hold onto theAdsManager
myself and manage its ownership of myAdEventListener
.I can provide a more comprehensive bug report if the above details are insufficient.
Version used: 2.9.0
The text was updated successfully, but these errors were encountered: