-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support variable speed / setPlaybackRate() in CastPlayer / Cast Extension #6784
Labels
Comments
@AquilesCanta - This seems like your domain, can you have a look at this? |
Hello! Any plans to support it? |
We are aware this could be done nicely with the Player API and it is on the list of features we want to add to CastPlayer. It's not something which is currently on a concrete roadmap I'm afraid. |
kim-vde
pushed a commit
that referenced
this issue
Sep 2, 2021
Issue: #6784 PiperOrigin-RevId: 393374139
christosts
pushed a commit
that referenced
this issue
Sep 21, 2021
Issue: #6784 PiperOrigin-RevId: 393374139
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Use case description
Exoplayer currently supports variable playback speed via
Player.setPlaybackParameters()
, however withinCastPlayer
this method is marked as unsupported. This is out of date as the currentRemoteMediaClient
API does support playback speed changes viasetPlaybackRate()
(docs)Proposed solution
Suggest CastPlayer expose
RemoteMediaClient.setPlaybackRate()
via it's ownsetPlaybackRate()
method and update the code comment currently seen inCastPlayer.setPlaybackParameters()
to reflect the current state of the RemoteMediaClient API and point developers to the new methods.Alternatives considered
The existing alternative is to call RemoteMediaClient directly, however there is no getter for this within CastPlayer, so it must be accessed via the clunky and verbose:
CastContext.getSharedInstance(context).sessionManager.currentCastSession.remoteMediaClient.setPlaybackRate()
The text was updated successfully, but these errors were encountered: