-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep DrmSession open when moving between secure content and clear ads using IMA extension #7011
Labels
Comments
@icbaker is taking a look at this. |
ojw28
pushed a commit
that referenced
this issue
Jul 3, 2020
316f8a8 implements session keepalive inside the This is available on the dev-v2 branch - please try it out and let us know if you spot any problems! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Use case description
When playing secure content with ads via the IMA extension the secure session is released. This means when the ad completes the drm session needs to be reacquired causing multiple network requests to the license URL (in case of widevine with http callback), and a spinner filled transition from ad to content for the user.
#4867 was closed recently, which solves the issue for specific scenarios I.E. multi period dash with a mixture of clear ads and DRM content, but the issue still persists with the IMA extension as the ads and the content are contained in separate
MediaSource
s juggled in anAdsMediaSource
.Recipe to reproduce
Proposed solution
No perfect solution comes to mind, but I'd imagine it would involve
AdsMediaSource
/CompositeMediaSource
retaining theDrmSession
somehow. Or maybe preventing the contentMediaSource
being released while the adMediaSource
is playing if we know it is due to play after the ad.Alternatives considered
Our current workaround is essentially proxying the
DrmSessionManager
and theDrmSession
s it hands out to block release calls until we know the entire playback session is complete. This prevents multiple license calls and makes the ad to contente playback smooth.The workaround seems to work ok, but it's a bit of a maintenance problem. Moving from 2.10 to 2.11 was a bit of a mess. I also wouldn't be surprised if we're leaking sessions etc.
The text was updated successfully, but these errors were encountered: