Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads are getting skipped by hitting play-pause during mid-roll with multiple ads #7340

Closed
nishantkp opened this issue May 6, 2020 · 1 comment
Assignees
Labels

Comments

@nishantkp
Copy link

nishantkp commented May 6, 2020

Issue description

Player is skipping ads by hitting play-pause during mid-roll with multiple ads.

Reproduction steps

  • Play a video with multiple ads in mid-roll
  • Open demo app
  • Launch VMSP pre-roll single ad, mid-roll optimized pod with 3 ads, post-roll single as(bumper around all ad breaks)
  • Let the mid-roll play
  • After first ad in mid-roll is played, hit play pause and it will skip 2nd ad, do it again and it will skip 3rd ad
  • And content will be resumed

Link to test content

  • demo app - Launch VMSP pre-roll single ad, mid-roll optimized pod with 3 ads, post-roll single as(bumper around all ad breaks)

A full bug report captured from the device

2020-05-06 12:50:23.813 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: state [eventTime=29.19, mediaPos=0.77, window=0, period=0, adGroup=1, ad=2, false, READY]
2020-05-06 12:50:23.814 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: isPlaying [eventTime=29.19, mediaPos=0.77, window=0, period=0, adGroup=1, ad=2, false]
2020-05-06 12:50:23.847 30891-30946/com.google.android.exoplayer2.demo D/eglCodecCommon: setVertexArrayObject: set vao to 3 (3) 22 27
2020-05-06 12:50:23.849 30891-30946/com.google.android.exoplayer2.demo D/eglCodecCommon: setVertexArrayObject: set vao to 0 (0) 22 2
2020-05-06 12:50:23.888 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: loading [eventTime=29.26, mediaPos=0.78, window=0, period=0, adGroup=1, ad=2, false]
2020-05-06 12:50:23.954 30891-30891/com.google.android.exoplayer2.demo W/ImaAdsLoader: Unexpected ad count in LOADED, 5, expected 3
2020-05-06 12:50:23.956 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: mediaPeriodReleased [eventTime=29.33, mediaPos=0.78, window=0, period=0, adGroup=1, ad=2]
2020-05-06 12:50:23.956 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: decoderDisabled [eventTime=29.33, mediaPos=0.78, window=0, period=0, adGroup=1, ad=2, video]
2020-05-06 12:50:23.956 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: decoderDisabled [eventTime=29.33, mediaPos=0.78, window=0, period=0, adGroup=1, ad=2, audio]
2020-05-06 12:50:23.956 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: decoderEnabled [eventTime=29.33, mediaPos=0.78, window=0, period=0, video]
2020-05-06 12:50:23.961 30891-30891/com.google.android.exoplayer2.demo W/IMASDK: Invalid internal message, ignoring. Please make sure the Google IMA SDK library is up to date. Message: gmsg://afma.google.com/videoDisplay?type=activate&sid=b0d420da-7d5f-4ac3-b32c-f44a6320ec03&dt=1588783823945
2020-05-06 12:50:23.965 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: decoderEnabled [eventTime=29.34, mediaPos=0.78, window=0, period=0, audio]
2020-05-06 12:50:23.965 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: timeline [eventTime=29.34, mediaPos=25.85, window=0, period=0, periodCount=1, windowCount=1, reason=DYNAMIC
2020-05-06 12:50:23.965 30891-30891/com.google.android.exoplayer2.demo D/EventLogger:   period [128.27]
2020-05-06 12:50:23.965 30891-30891/com.google.android.exoplayer2.demo D/EventLogger:   window [128.27, true, false]
2020-05-06 12:50:23.965 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: ]
2020-05-06 12:50:23.971 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: tracks [eventTime=29.34, mediaPos=25.85, window=0, period=0, 
2020-05-06 12:50:23.971 30891-30891/com.google.android.exoplayer2.demo D/EventLogger:   Renderer:0 [
2020-05-06 12:50:23.971 30891-30891/com.google.android.exoplayer2.demo D/EventLogger:     Group:0, adaptive_supported=N/A [
2020-05-06 12:50:23.972 30891-30891/com.google.android.exoplayer2.demo D/EventLogger:       [X] Track:0, id=1, mimeType=video/avc, res=1280x720, supported=YES
2020-05-06 12:50:23.972 30891-30891/com.google.android.exoplayer2.demo D/EventLogger:     ]
2020-05-06 12:50:23.972 30891-30891/com.google.android.exoplayer2.demo D/EventLogger:   ]
2020-05-06 12:50:23.972 30891-30891/com.google.android.exoplayer2.demo D/EventLogger:   Renderer:1 [
2020-05-06 12:50:23.972 30891-30891/com.google.android.exoplayer2.demo D/EventLogger:     Group:0, adaptive_supported=N/A [
2020-05-06 12:50:23.972 30891-30891/com.google.android.exoplayer2.demo D/EventLogger:       [X] Track:0, id=2, mimeType=audio/mp4a-latm, channels=2, sample_rate=44100, language=und, supported=YES
2020-05-06 12:50:23.972 30891-30891/com.google.android.exoplayer2.demo D/EventLogger:     ]
2020-05-06 12:50:23.972 30891-30891/com.google.android.exoplayer2.demo D/EventLogger:   ]
2020-05-06 12:50:23.972 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: ]
2020-05-06 12:50:23.974 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: loading [eventTime=29.35, mediaPos=25.85, window=0, period=0, true]
2020-05-06 12:50:23.974 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: state [eventTime=29.35, mediaPos=25.85, window=0, period=0, false, BUFFERING]
2020-05-06 12:50:23.979 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: mediaPeriodReadingStarted [eventTime=29.35, mediaPos=25.85, window=0, period=0]
2020-05-06 12:50:23.979 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: downstreamFormat [eventTime=29.35, mediaPos=25.85, window=0, period=0, id=1, mimeType=video/avc, res=1280x720]
2020-05-06 12:50:23.980 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: decoderInputFormat [eventTime=29.35, mediaPos=25.85, window=0, period=0, video, id=1, mimeType=video/avc, res=1280x720]
2020-05-06 12:50:23.981 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: downstreamFormat [eventTime=29.35, mediaPos=25.85, window=0, period=0, id=2, mimeType=audio/mp4a-latm, channels=2, sample_rate=44100, language=und]
2020-05-06 12:50:23.981 30891-30891/com.google.android.exoplayer2.demo D/EventLogger: decoderInputFormat [eventTime=29.35, mediaPos=25.85, window=0, period=0, audio, id=2, mimeType=audio/mp4a-latm, channels=2, sample_rate=44100, language=und]

Version of ExoPlayer being used

2.10.7 and onwards

Device(s) and version(s) of Android being used

Any device with api 21 and above. Did not checked on lower versions.

@andrewlewis
Copy link
Collaborator

I've verified this is fixed by migrating to the new IMA SDK preloading APIs (fa7d26d), and that change should be in a release soon. (This is probably the same underlying issue as #4140.)

@ojw28 ojw28 removed the needs triage label Jul 1, 2020
@google google locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants