Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible video coding with mpeg1video in Mp4Extractor #8257

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Compatible video coding with mpeg1video in Mp4Extractor #8257

merged 1 commit into from
Nov 24, 2020

Conversation

xufuji456
Copy link
Contributor

Hello, guy of developers. I found that it doesn't support mpeg1video in Mp4Extractor. Therefore, I add mpeg1video which name is m1v to make it compatible.

Here is the testing video:https://drive.google.com/file/d/116_x0RwRYEAcCDnQyOlTHMHqPe67D3-J/view?usp=sharing

@kim-vde
Copy link
Contributor

kim-vde commented Nov 23, 2020

The link to the test video is broken. Could you please fix it? If you're unable to share test content publicly, please send it to [email protected] using subject "Issue #8257".

@xufuji456
Copy link
Contributor Author

Maybe you could use this link to test: https://drive.google.com/file/d/116_x0RwRYEAcCDnQyOlTHMHqPe67D3-J/view

@kim-vde
Copy link
Contributor

kim-vde commented Nov 23, 2020

Out of curiosity, do you know how the video is rendered? Does the test device you use have an mpeg1 video decoder?

@xufuji456
Copy link
Contributor Author

xufuji456 commented Nov 24, 2020

@kim-vde I apologize for not being clear about the situation. Take into consideration the compatibility, We extend the video SoftDecoder with FFmpeg. Therefore, we decode the mpeg1 video by the decoder of mpeg1video, maybe it couldn't work on MediaCodec.

@kim-vde kim-vde merged commit 1cd0851 into google:dev-v2 Nov 24, 2020
icbaker pushed a commit that referenced this pull request Nov 30, 2020
PiperOrigin-RevId: 344057097
@google google locked and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants