-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onPlayerError from 403 when playing HLS event playlist near live on r2.15.0 #9390
Comments
If the issue is as described, then it's definitely a bug. Are you able to provide a stream that we can reproduce with somehow? |
@ojw28 sorry, I am not able to provide an example stream. |
This was originally reported on #9390. There was a bug that when HLS loads failed, the player would endlessly retry and never fail with a player error. This change fixes a bug in HlsSampleStreamWrapper.onPlaylistError() which would return true for a playlist whose load encountered an error but could not be excluded, whereas the method should return false. Issue: #9390 #minor-release PiperOrigin-RevId: 397045802
We performed a similar test to the one you described ("the server starts responding with 403") and spotted a bug. We submitted a fix (see linked commit above) which is already pushed to the dev-v2 branch and will be included in the upcoming 2.15.1 minor release. I'll close this issue for now, feel free to re-open if the fix did not fully address the issues you're observing. |
This was originally reported on #9390. There was a bug that when HLS loads failed, the player would endlessly retry and never fail with a player error. This change fixes a bug in HlsSampleStreamWrapper.onPlaylistError() which would return true for a playlist whose load encountered an error but could not be excluded, whereas the method should return false. Issue: #9390 PiperOrigin-RevId: 397045802
Hi,
On release r2.15.0 I've noticed that onPlayerError isn't called when a 403 HTTP error occurs when playing an HLS event playlist near the end. I was using r2.14.2 and r 2.13.3 before and both worked fine, problems started from r2.15.0. I was wondering if there's a new Listener I'm supposed to be using to catch 403 errors in r2.15.0 or is this a bug? To test, I start playback then invalidate the token so the server returns 403 and the player becomes stuck throwing exceptions every few milliseconds:
If I play the same event playlist from the start (or use a vod playlist) and invalidate the token, the player acts as expected, throws the same exception every 5 seconds:
then when buffer runs out throws an ExoPlaybackException and calls onPlayerError:
I am testing using most recent ExoPlayer demo just added a print in onPlayerError in PlayerActivity.java:
The text was updated successfully, but these errors were encountered: