-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ATTRIBUTE_PATTERN in SessionDescriptionParser #9430
Labels
Comments
Support for special characters is added in RFC4566, while we implemented RFC2327. There will be a patch soon. |
kim-vde
pushed a commit
that referenced
this issue
Sep 17, 2021
Issue: #9430 The current supported SDP (RFC2327) spec only allows for alpha-numeric characters in the attribute-field. RFC4566 (section 9, token type) allowed extra characters, and this CL adds the support. PiperOrigin-RevId: 397301173
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Can you change SessionDescriptionParser?
I would like to change:
ATTRIBUTE_PATTERN = Pattern.compile("([0-9A-Za-z-]+)(?::(.*))?");
to
ATTRIBUTE_PATTERN = Pattern.compile("([0-9A-Za-z-_]+)(?::(.*))?");
add
_
The problem is that my camera's response contains the line
a=Media_header:MEDIAINFO=494D4B48010100000400010000000000000000000000000000000000000000000000000000000000;
and an exception is thrown:The text was updated successfully, but these errors were encountered: