Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requeue MSG_DOWNLOAD_UPDATE when received before the service is started. #6828

Conversation

daveoxley
Copy link

This fixes the case where downloads get stuck when network requirements are met after previously not being met. It resends the update messages once the service is attached to the helper. Also added logging when this occurs:

2020-01-05 11:55:45.391 3204-3204/com.google.android.exoplayer2.demo D/DownloadService: onDownloadChanged with null service. Queuing to resend message later.
2020-01-05 11:55:45.415 3204-3204/com.google.android.exoplayer2.demo D/DownloadService: 1 messages to resend.

Fixes #6798

@ojw28 ojw28 self-assigned this Jan 5, 2020
@ojw28
Copy link
Contributor

ojw28 commented Jan 17, 2020

We fixed the ref'd issue with a different set of changes, so this is no longer required.

@ojw28 ojw28 closed this Jan 17, 2020
@google google locked and limited conversation to collaborators Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants