Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #4352 resolved using handler on handling messages #6932

Closed
wants to merge 1 commit into from

Conversation

kashu1209
Copy link

No description provided.

@ojw28
Copy link
Contributor

ojw28 commented Jan 30, 2020

If not blocking where we currently block was a valid solution to the referenced issue, we'd just remove the blockUntilDelivered() calls. As per the issue itself, this is not a valid fix.

@ojw28 ojw28 closed this Jan 30, 2020
@kashu1209
Copy link
Author

kashu1209 commented Jan 30, 2020 via email

@ojw28
Copy link
Contributor

ojw28 commented Jan 30, 2020

This is already explained by the issue you're referencing as being fixed by this pull request. For example see #4352 (comment).

@google google locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants