Fix ProgressiveDownloader reporting wrong doubled values of downloa…
#8579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded bytes and percent after 'No space left on device' `IOException` and retry. This case added as unit test in `ProgressiveDownloaderTest` `download_afterSinkException_reportsValidProgress()` method. The main source of problem was that in `CacheDataSink` underlying file got removed after `OutputStream.flush()` failed in `closeCurrentOutputStream()` method. This information doesn't propagate to CacheWriter logic. And wrong progress/bytesCached reported when user calls `cache()` method second time. To fix this we need to propagate information about file getting removed and set `initialized` flag to false. There was a corner case where `OutputStream` throws exception either in `write()`` and in `flush()`` methods. The second error was lost, but second is a important one because in it a file was removed. To fix this case we need to replace original exception with second one instead of using `Util.closeQuietly()` method.
|
Thanks for sending this! I agree that there's an issue here, although I concluded that the proposed solution was a little invasive. I have merged c067ee8 instead, which I think is sufficient to resolve the problem, so I will go ahead and close this. Please let us know if you still see the problem, either here or by filing a new issue! As an aside, there are some other known issues affecting |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
ProgressiveDownloaderreporting wrong doubled values of downloaded bytes and percent after 'No space left on device'IOExceptionand retry.This case added as a unit test in
ProgressiveDownloaderTestdownload_afterSinkException_reportsValidProgress()method.The main source of problem was that in
CacheDataSinkunderlying file got removed afterOutputStream.flush()failed incloseCurrentOutputStream()method. This information doesn't propagate to CacheWriter logic. And wrong progress/bytesCached reported when user callscache()method second time.To fix this we need to propagate information about file getting removed and set
initializedflag to false.There was a corner case where
OutputStreamthrows exception either inwrite()and inflush()methods. The second error was lost, but the second is an important one because in it a file was removed. To fix this case we need to replace the original exception with the second one instead of usingUtil.closeQuietly()method.For context, the stacktrace when ENOSPC raised by device:
But for better picture please see Unit Tests.
To reproduce the bag in this branch:
CacheWriterline 151 comment outinitialized = falseProgressiveDownloaderTest.download_afterSinkException_reportsValidProgress