drop example extra-requirements #178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's exactly the same as the dataflow one so let's keep it simple and only provide a "dataflow" one.
|
At this point it does seem redundant, but when/if we have more examples (that use e.g., pytorch, scipy, etc), it would be nice to be able to install all example deps with |
|
I see you point, maybe let's leave this one on stale for now and see what can be done elswhere (I don't fully understand the different level of dependencies yet) |
|
Sounds good. Will leave open for now as a reminder to keep dep organization in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's exactly the same as the dataflow one so let's keep it simple and only provide a "dataflow" one.