Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Brave to the list of supported user agents #56

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Add Brave to the list of supported user agents #56

merged 1 commit into from
Jul 25, 2023

Conversation

fmarier
Copy link
Contributor

@fmarier fmarier commented Jul 21, 2023

Support in Brave can be tested using https://no-sct.badssl.com/ and https://sct-exempted.bravesoftware.com/.

@fmarier fmarier requested a review from a team as a code owner July 21, 2023 19:18
@fmarier fmarier requested a review from getagit July 21, 2023 19:18
roger2hk
roger2hk approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@roger2hk roger2hk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference:
brave/brave-core#17944
https:/brave/brave-browser/wiki/TLS-Policy#certificate-transparency

@roger2hk roger2hk merged commit 131395e into google:master Jul 25, 2023
1 check passed
@roger2hk
Copy link
Contributor

image

@fmarier fmarier deleted the add-brave branch July 25, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roger2hk roger2hk roger2hk approved these changes

@getagit getagit Awaiting requested review from getagit getagit is a code owner automatically assigned from google/certificate-transparency

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmarier @roger2hk