Fix ForEachIterable error when calling iterator method without 'this' #2260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The ForEachIterable check will NPE when generating a fix for an instance where the method returning the iterator is a member function, (ie called with
this
as the receiver). This causesgetReceiver
to return null, as expected, but then will trigger a NPE fromstate.getSourceForNode
. The other two casesgetReceiver
can return null are for static methods, this will never occur though since the earlierITERATOR
matcher does not match static methods.PR Contribution
If
getReceiver
returns null then the fix will iterate over 'this' since getReceiver is returning null forgetReceiver(this.iterator())
so in reality should returnthis
. The new case, and associated fix, can be seen in the unit test.