Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: module name → com.google.errorprone.annotations #4321

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

copybara-service[bot]
Copy link
Contributor

fix: module name → com.google.errorprone.annotations

Summary

Fixes the module name: com.google.errorprone.annotationcom.google.errorprone.annotations. Amends the OSGi build not to include Automatic-Module-Name in the MANIFEST.MF for the annotations project.

Changelog

  • fix: name in module-info.java for annotations module
  • fix: don't emit Automatic-Module-Name in annotations module
  • chore: preserve all other aspects of OSGi and JAR builds

Relates to discussion in #4311. Double checked for correct JAR structure; see these screenshots.

cc / @cushon @ben-manes

Fixes #4317

FUTURE_COPYBARA_INTEGRATE_REVIEW=#4317 from sgammon:fix/module-name bc52c58

## Summary

Fixes the module name: ~~`com.google.errorprone.annotation`~~ → `com.google.errorprone.annotations`. Amends the OSGi build not to include `Automatic-Module-Name` in the `MANIFEST.MF` for the `annotations` project.

## Changelog

- fix: name in `module-info.java` for `annotations` module
- fix: don't emit `Automatic-Module-Name` in `annotations` module
- chore: preserve all other aspects of OSGi and JAR builds

Relates to [discussion](#4311 (comment)) in #4311. Double checked for correct JAR structure; see [these screenshots](#4311 (comment)).

cc / @cushon @ben-manes

Fixes #4317

COPYBARA_INTEGRATE_REVIEW=#4317 from sgammon:fix/module-name bc52c58
PiperOrigin-RevId: 615114274
@copybara-service copybara-service bot merged commit 9d99ee7 into master Mar 12, 2024
@copybara-service copybara-service bot deleted the test_615074017 branch March 12, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant