Add more SMS functionality #130
Conversation
googlebot
added
the
cla: yes
cmd/server/assets/home.html
Outdated
| <input type="tel" id="phone" name="phone" class="form-control" /> | ||
| </div> | ||
| <small class="form-text text-muted"> | ||
| This must be a phone number capable of receiving SMS text messages. |
There was a problem hiding this comment.
hmmm..
Should we have a drop down for country code and have it default to the one configured by the PHA.
This seems like such an easy thing to miss.
There was a problem hiding this comment.
So, Twilio is "smart" in that by default it uses the country code associated with the account if one isn't provided. I'm thinking we leave this as-is for now and maybe iterate on it later? I originally went down a path of some client-side javascript stuff, but the twilio api error responses are pretty good.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @mikehelmick