Bumps Flax to v0.4.0 #1825
Bumps Flax to v0.4.0 #1825
Conversation
|
Is it too much to ask that #1803 , which addresses most inconsitencies with complex numbers and dtypes in general, be merged before you release 0.4? |
|
#1803 is also technically breaking (albeit not in a huge fashion), in that as of master right now, results will always be downcasted to float32 while #1803 will switch to numpy promotion rules for output dtype of layers. It might be good for downstream users to minimise breaking changes in a single release. |
The PR is still in draft stage so I think we shouldn't block on that PR. The release process is pretty lightweight so we can make a new release soon after it lands. |
Thanks for the feedback! I took a look at #1803, but that is a really big change and I currently can't quite determine when it will be done. Given that we want to remove our old API as soon as possible, like @jheek it seems better to go ahead and release new version now. Once the dtype issues have been resolved we can release another one! |
|
And if it's a breaking change, that's a good reason to finish *a* release
before merging it, and then doing another release with the breaking
change...
…On Thu, Jan 27, 2022 at 3:41 PM copybara-service[bot] < ***@***.***> wrote:
Merged #1825 <#1825> into main.
—
Reply to this email directly, view it on GitHub
<#1825 (comment)>, or
unsubscribe
<https:/notifications/unsubscribe-auth/AAAJFUV3MWMKPLKMF5UIMLDUYFKS7ANCNFSM5M5TA7EA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Moving from 0.3.6 --> 0.4.0 since we are removing flax.deprecated, which I think deserves a new number! 😄