Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some browser fixes #590

Merged
merged 2 commits into from
Jan 9, 2019
Merged

fix: some browser fixes #590

merged 2 commits into from
Jan 9, 2019

Conversation

alexander-fenster
Copy link
Contributor

@alexander-fenster alexander-fenster commented Jan 9, 2019 •
edited
Loading

Browser stuff again here. The new endpoint for revoke introduced for #434 supports only POST, and does not support JSONP, so we don't need this.

Also, making sure we get our warnings in browser.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 9, 2019
@alexander-fenster alexander-fenster changed the title fix: no jsonp support fix: some browser fixes Jan 9, 2019
@JustinBeckwith JustinBeckwith merged commit d3fb55e into master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-fenster @JustinBeckwith @googlebot