Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concurrency issue in GTMFetcherCleanedUserAgentString() causing crashes #359

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Fix concurrency issue in GTMFetcherCleanedUserAgentString() causing crashes #359

merged 2 commits into from
Aug 16, 2023

Conversation

bhamiltoncx
Copy link
Member

Fixes #358 .

Tested:
Before and after fix, ran:

for i in {1..100}; do swift test -c release --filter GTMSessionFetcherUserAgentTest >/dev/null 2>&1 && echo "PASS" || echo "FAIL"; done

Before fix, test failed almost every time.
After fix, test passes every time.

@thomasvl thomasvl merged commit 4438869 into google:main Aug 16, 2023
21 checks passed
@bhamiltoncx bhamiltoncx deleted the user-agent-concurrency branch August 16, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasvl thomasvl thomasvl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concurrency issue in GTMFetcherCleanedUserAgentString()
2 participants
@bhamiltoncx @thomasvl