Add error handing to fetching a chunk from file uploads. #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same logic as what happens for non-file based uploaded, it if something happens to cause a failure to collect a subrange, then it will fail the upload instead of the current crash that has occasionally been seen. For both cases (Data or file based), if we can get better repos, there might be some better checks to do in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same logic as what happens for non-file based uploaded, it if something happens to cause a failure to collect a subrange, then it will fail the upload instead of the current crash that has occasionally been seen.
For both cases (Data or file based), if we can get better repos, there might be some better checks to do in the future.