Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to JSR 305 in Javadoc are broken #2479

Closed
arend-von-reinersdorff opened this issue May 13, 2016 · 3 comments
Closed

Links to JSR 305 in Javadoc are broken #2479

arend-von-reinersdorff opened this issue May 13, 2016 · 3 comments
Labels
type=api-docs Change/add API documentation type=defect Bug, not working as expected
Milestone

Comments

@arend-von-reinersdorff
Copy link
Contributor

For example Javadoc for package base link to @ParametersAreNonnullByDefault results in 404.

Affects all links to JSR 305 annotations.

As far as I can tell JSR 305 is not maintained anymore. Maybe the easiest solution would be to not link to the JSR 305 annotations in the Javadoc.

@lowasser
Copy link
Contributor

Google Code is being turned down, but I'm not sure whether or not JSR 305 has just moved?

@ispringer
Copy link

There doesn't appear to be a new home. Perhaps you could just update the Guava build to download https://repo1.maven.org/maven2/com/google/code/findbugs/jsr305/3.0.1/jsr305-3.0.1-javadoc.jar, unzip it, and then point javadoc at the dir where it was unzipped.

@arend-von-reinersdorff
Copy link
Contributor Author

@ispringer Or point to javadoc.io which does what you describe:
http://www.javadoc.io/doc/com.google.code.findbugs/jsr305/3.0.1

@cgdecker cgdecker added type=defect Bug, not working as expected type=api-docs Change/add API documentation labels Nov 2, 2016
@cgdecker cgdecker added this to the 21.0 milestone Nov 2, 2016
cgdecker added a commit that referenced this issue Nov 3, 2016
(Note: This will break the public Guava GWT tests. We'll come back to fix them.)

Fixes #2585, #2479, #2029, and probably various other issues :)

Also relevant: #2591

-------------
Created by MOE: https:/google/moe
MOE_MIGRATED_REVID=138100073
@cpovirk cpovirk closed this as completed Nov 3, 2016
cpovirk pushed a commit that referenced this issue Nov 4, 2016
Fixes #2479

Fixes #2628

-------------
Created by MOE: https:/google/moe
MOE_MIGRATED_REVID=138184010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type=api-docs Change/add API documentation type=defect Bug, not working as expected
Projects
None yet
Development

No branches or pull requests

5 participants